Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow time entry for custom durations; show time elapsed and remaining during video playback #3661

Merged
merged 12 commits into from
Dec 9, 2024
Merged

feat: allow time entry for custom durations; show time elapsed and remaining during video playback #3661

merged 12 commits into from
Dec 9, 2024

Conversation

sircharlo
Copy link
Owner

@sircharlo sircharlo commented Dec 6, 2024 •
edited
Loading

To do

  • Move customDurations to media props
  • Properly set/emit updates to custom duration props
  • Fix media player page to respect custom durations

Related to #3593 & #3651

@github-actions github-actions bot added the enhancement New feature or request label Dec 6, 2024
@mtdvlpr mtdvlpr changed the title fix: groundwork to allow time entry for custom durations feat: allow time entry for custom durations Dec 6, 2024
@sircharlo sircharlo changed the title feat: allow time entry for custom durations feat: allow time entry for custom durations; show time elapsed and remaining during video playback Dec 6, 2024
@sircharlo sircharlo mentioned this pull request Dec 6, 2024
Closed
3 tasks
@sircharlo sircharlo marked this pull request as ready for review December 9, 2024 17:16
@sircharlo
Copy link
Owner Author

LGTM!

@sircharlo sircharlo merged commit d3c9ca4 into master Dec 9, 2024
10 checks passed
@sircharlo sircharlo deleted the feat/allow-custom-duration-manual-input branch December 9, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sircharlo @mtdvlpr